Store lower-case team name, when creating NS #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes the team name to be lower-cased before we write the rbac.yaml and variables.tf files. This fixes a problem later on, when the user tries to create an ECR - if they have upper-case letters in their team name, the ECR name generated by our terraform module will be rejected. NB: This change is not tested by the unit tests, since those don't cover the relevant part of the code.
mogaal
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes the team name to be lower-cased
before we write the rbac.yaml and variables.tf
files.
This fixes a problem later on, when the user tries
to create an ECR - if they have upper-case letters
in their team name, the ECR name generated by our
terraform module will be rejected.
NB: This change is not tested by the unit tests,
since those don't cover the relevant part of the
code.